Commit 90faf700 authored by DQ's avatar DQ
Browse files

Enhance: output the stdout of gen cert script

use popen replace check_all
Signed-off-by: default avatarDQ <>
parent 06d955c6
......@@ -2,7 +2,8 @@ import os
import sys
import click
import pathlib
from subprocess import check_call, PIPE, STDOUT
import logging
from subprocess import Popen, PIPE, STDOUT, CalledProcessError
from utils.cert import openssl_installed
from utils.misc import get_realpath
......@@ -25,8 +26,8 @@ def gencert(path, days):
if not os.path.exists(path):
click.echo('path {} not exist, create it...'.format(path))
os.makedirs(path, exist_ok=True)
shell_stat = check_call([gen_tls_script, days], stdout=PIPE, stderr=STDOUT, cwd=path)
if shell_stat != 0:
click.echo('Can not generate internal tls certs')
with Popen([gen_tls_script, days], stdout=PIPE, stderr=STDOUT, cwd=path) as p:
for line in p.stdout:
click.echo(line, nl=False)
if p.returncode != 0:
raise CalledProcessError(p.returncode, p.args)
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment