Strange test in ConcreteFrame::Stallion
There is a strange test on a variable on the following line : https://gitlab.in2p3.fr/ip2i_gamma/adf/-/blob/preprod/cpp/ADF_Frame.cpp#L278
The "toadd" variable contains the value (8u-offset), offset being X%8. So offset is in [0,7] and toadd in [1,8]. As a result testing if toadd is greater than 0 is useless.
Still, is seems that this portion of code tries to add a padding to 64 bits so isn't the addition of 8 chars useless? Shouldn't the test be if ( toadd < 8u )
?