Missing TPS deviations from TPS in the TCB timer deviations
The TCB timer deviations represent the deviations of the onboard clock time with respect to the TCB. They should contain the deviations of the clock with respect to the spacecraft proper time (clock offset, noise and drifts), in addition to the deviation of the TPS with respect to the TPS (relativistic effect).
TCB timer deviations have been initially implemented in !81 (merged) as
self.tcb_timer_deviations = \
self.clock_offsets + \
self.clock_freqoffsets * self.telemetry_t + \
self.clock_freqlindrifts * self.telemetry_t**2 / 2 + \
self.clock_freqquaddrifts * self.telemetry_t**3 / 3 + \
self.tps_proper_time_deviations + \
self.tcb_sync_noises
and missed clock noise (integrated to get a time). This was fixed in !108 (merged). Issues with sampling of the TCB timer deviations were addressed in !110 (merged), but it seems that it resulted in the tps_proper_time_deviations
not being included (they are still read from orbit files).
This is a bug that we need to fix.
Also, we might reconsider the naming of these quantities (TCB timer deviations, TPS proper time deviations, etc.) as they are complicated to remember, not super consistent nor explicit.