Skip to content

all: moves to camel case naming

Sebastien Binet requested to merge camelCase into master

Created by: TacoVox

Hi guys, I had a stab at https://github.com/gonum/hdf5/issues/37 and renamed the variables. Took me a bit longer than expected as so many variables are affected and maybe I did not even catch them all...

Nevertheless, some points are still up for discussion and I hope we can discuss them as part of this PR:

What shall we do about the Datatype vs. DataType issue? I saw that @sbinet had once a stab at this. I still suggest that we move what is called Datatype to DataType as part of this PR and then rethink later if we want to move to what you said in https://github.com/gonum/hdf5/pull/9, @kortschak. The same goes for Dataspace which should maybe also be called DataSpace?

Id vs. ID. Right now I moved everything to Id, but I am not quite sure if ID is the better way. The go standard lib uses the prior while golint suggest the latter. Any opinion?

_go_types in h5t_types.go. Should we rename e.g. _go_int8_t to goInt8T?

ALL_CAPS_VARS as we have them in h5t_shim.go should stay as they are, right?

Merge request reports

Loading