Skip to content
Snippets Groups Projects

vg/vgtex: fix yet another NewDocument-related bufio bug

Merged Sebastien Binet requested to merge sbinet-gonum:vg-tex-fix into master

Merge request reports

Merged by avatar (Jan 12, 2025 6:44pm UTC)

Merge details

  • Changes merged into with b78d9cc8.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Created by: eaburns

    LGTM. Do we have any to make tests so this doesn't keep happening?

  • in this particular case, it was mostly a semantics issue but the generated LaTeX file was correct. (that's why the test was passing.) it was a bug in waiting though, if some refactoring had happened.

Please register or sign in to reply
Loading