Skip to content
Snippets Groups Projects

remove convenience.js and collect it from gnome.org instead

Merged Dirk HOFFMANN requested to merge refract/#121-import-convenience.js-from-source into develop

Created by: ghost

convinience.js is provided by the main gnome-shell project as boilerplate for extension developers. As there is no viable dependency management to speak of we can either ship a verbantim copy ourself as part of the repo or (as this PR introduces) manually fetch the authorative file straight from the gnome project when building the extension.

This introduces wget as a dependency for the collect make target.

Merge request reports

Merged by avatar (Apr 17, 2025 12:21pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Created by: elbenfreund

    Review: Changes requested

    Please provide some short description so the reasoning is clear when we look it up in 6 month down the road. Whilst I think copying the file from gnome is bizarre in its own way, it seems cleaner and more transparent at least as shipping our own verbatim copy. I guess this would cause some serious issues with running any kind of testsuite, but as it does not look like gnome-shell bothers nor supports testing we should be fine for now...

  • Created by: elbenfreund

    @border0464111 ping :)

  • Created by: elbenfreund

    Review: Approved

  • Merged by: elbenfreund at 2017-10-10 17:43:50 UTC

Please register or sign in to reply
Loading