Skip to content

Gnome 3.32 support - alternative pull request

Dirk HOFFMANN requested to merge github/fork/mwilck/GNOME-3.32 into develop

Created by: mwilck

This PR aims to fix https://github.com/projecthamster/hamster-shell-extension/issues/307. It is almost equivalent to https://github.com/projecthamster/hamster-shell-extension/pull/308, and very heavily based on @ernestask's work there.

Differences are:

  • The branch is based on @hedayat's work for 3.30. As such, the first 5 commits up to 3e754990 are actually aimed at 3.30, and are partially reverted for 3.32 later in the series.
  • It's split into several commits for easier review
  • It does not introduce "Arrow" style function syntax (yet, this could be easily added later).
  • It adds a few comments for jshint to avoid problems in make test-style
  • It marks only GNOME 3.32 as supported in this version (IMO necessary; other extensions do the same).

If we want to support older GNOME versions in the future, we'll need to fork.

Note that the only parts that are necessary to make hamster-shell-extension work with GNOME 3.32 are 78bc2ff (plus the fix 76e961c) and 0621854.

Merge request reports