Skip to content

base Fact comparison on main attributes

Dirk HOFFMANN requested to merge github/fork/ederag/fix_cli_stop into master

Created by: ederag

Seems to fix issue #381 (closed).

The fact.id is not modified when the fact.end_time changes, but comparison of facts was based on fact.id alone, and for some reason, this lead python to not rebind self.facts to the new facts after https://github.com/projecthamster/hamster/blob/843f3638e62beff2f4b0145cdd362bc7b30cb0ee/src/hamster/widgets/facttree.py#L400 => assigned but not identical. Weird. (further analysis in #381 (closed))

Note: fact.id is the hamster database id, not the python id(fact).

With this PR, facts comparison is based on the main attributes. (excluding id and activity_id attributes that are database implementation details)

Merge request reports