Skip to content
Snippets Groups Projects
  1. Apr 03, 2019
  2. Jul 27, 2018
  3. Jul 23, 2018
    • Lionel GUEZ's avatar
      Put small test input files under version control. Rename directory · 9c204185
      Lionel GUEZ authored
      Stdin to Input. Two input dir provided for in tests.json: $input_dir
      and $large_input_dir.
      
      Rename everywhere variable nearby_extr to outside_points to avoid
      confusion with function nearby_extr. Rename file "nearby_extr.csv" to
      "outside_points.csv".
      
      In procedure nearby_extr, include in the selection extrema with
      different sign, even if they do not have sufficient amplitude.
      
      Bug fix in read_eddy: use the value of read attribute to define
      e%interpolated.
      9c204185
  4. Jul 17, 2018
  5. Jul 13, 2018
  6. Mar 30, 2018
    • Lionel GUEZ's avatar
      When we do not find an outermost contour or a max-speed contour, · 94515cc5
      Lionel GUEZ authored
      instead of defining the component ssh to the ssh of the extremum or to
      the ssh of the outermost contour, use a missing value flag
      (1e4). Also, when radius4 >= 2 and the max speed contour is the
      outermost contour, use missing value flag in the ssh component of max
      speed contour instead of ssh on outermost contour. This makes clearer
      output.
      
      Add function null_ssh_contour.
      
      In procedure get_1_outerm, simplify the comparison of level_try and
      level_good. So we do not need any longer the dummy argument
      ssh_extremum.
      94515cc5
  7. Mar 19, 2018
  8. Dec 20, 2017
  9. Dec 15, 2017
    • Lionel GUEZ's avatar
      In procedure get_snapshot, encountered rounding error that led to · 7d99eff6
      Lionel GUEZ authored
      out-of-range index so add min when calculating urc.
      
      Bug fix in procedure good_contour. polygon_contains_point should not
      be called if polyline is not closed.
      
      Procedure polygon_contains_point became unpure so remove pure for
      procedure inside_4 too.
      
      In program test_good_contour, read corner and step from namelist
      rather than from coordinates in NetCDF file. Makes it possible to use
      the same NetCDF file with different coordinates. Also read
      outside_points from a file rather than standard input so there is no
      need to specify in advance the number of outside points.
      
      Take into account the possibility that no outermost contour was found
      in program test_set_outermost_contour. Also, use fixed names for input
      files because it is not convenient to require a particular order of
      these two files on the command line.
      7d99eff6
  10. Dec 11, 2017
    • Lionel GUEZ's avatar
      Bug fix in test_set_outermost_contour. e%ssh_extremum must be · ccc61328
      Lionel GUEZ authored
      defined. Also, allow test_set_outermost_contour to read ssh from a
      NetCDF variable with a degenerate time coordinate or with no time
      coordinante.
      
      "stdout" key became optional in "tests.json" and "directory" key
      became "title", with no indication of directory.
      ccc61328
  11. Dec 07, 2017
    • Lionel GUEZ's avatar
      Bug fix in procedure write_eddy: null shape for null outermost · 048507ad
      Lionel GUEZ authored
      contour.
      
      Read whole NetCDF files in program test_set_outermost_contour instead
      of specifying a reading window. Simpler to prepare a file outside
      the Fortran program, as in program test_local_extrema. Also, compute
      step from read longitude and latitude.
      048507ad
  12. Dec 04, 2017
    • Lionel GUEZ's avatar
      If an outermost contour has exactly the minimum amplitude, it is · 0ce6b1b4
      Lionel GUEZ authored
      acceptable. So define flat_extr by a strict inequality in procedure
      get_snapshot.
      
      Procedure set_outermost_contour no longer has a dummy argument
      noise_around. We no longer call outermost_possible_level so we do not
      have an artificial discontinuity of results with and without maximum
      amplitude. We abandon the idea of reducing the amplitude of initial
      level_good compared to innermost_level: problem of consistence with
      get_snapshot, and it does not seem worth the trouble, just abandon
      those problematic extrema. Allow for null outermost_contour instead of
      aborting.
      
      In procedure get_snapshot, s%list_vis(i)%suff_amp is first defined
      only if flat_extr(i). Also we are no longer sure that
      set_outermost_contour finds an outermost contour so we have to test
      this to define s%list_vis(i)%suff_amp. noise_around is now defined
      only for flat_extr(i) and s%list_vis(i)%suff_amp. Also, since we may
      not find an outermost contour even if not flat_extr(i), we update
      s%extr_map after the second call to set_outermost_contour.
      
      In procedure local_extrema, we use the mask diff_center instead of
      mask_center. So we no longer need procedure construct_mask_center. In
      procedure local_extrema, we ignore one in two adjacent degenerate
      extrema instead of aborting.
      
      In plot_snapshot.py, color extrema and allow for null outermost
      contour.
      
      Synthesize output in test_local_extrema.py.
      0ce6b1b4
  13. Oct 31, 2017
    • Lionel GUEZ's avatar
      get_snapshot and test_get_snapshot are back, implementing the · 16d0b6fa
      Lionel GUEZ authored
      low-amplitude threshold, min_amp.
      
      Add component suff_amp to derived type eddy. Write this component in
      extremum_$m.dbf.
      
      In shapefiles, write positions of vertices in degrees rather than
      radians.
      
      test_get_snapshot reads the whole domain of input NetCDF files instead
      of selecting a window through a namelist. This is clearer and more
      convenient. Same in test_get_snapshot.py, test_local_extrema and
      test_local_extrema.py.
      
      In test_get_snapshot.py, annotate extrema instead of inserting a
      legend.
      
      More correct names: radian_per_degree to deg_over_rad,
      degree_per_radian to rad_over_deg.
      16d0b6fa
  14. Oct 13, 2017
  15. Sep 26, 2017
  16. Sep 25, 2017
    • Lionel GUEZ's avatar
      Starting to change the algorithm for low-amplitude · 6d746fb7
      Lionel GUEZ authored
      threshold. outermost_contour becomes set_outermost_contour. get_eddy
      disappears: it will be absorbed in get_snapshot. get_snapshot is
      temporarily broken so we do not compile test_get_snapshot.
      
      set_outermost_contour is in charge of finding nearby_extr and the
      initial value of level_try (get_outermost_contour was not). The method
      for this depends on the value of noise_around. The rest of the
      processing in set_outermost_contour is identical to what was done in
      get_outermost_contour.
      
      Made test_max_speed_contour_ssh more general: longitude-latitude
      window and eddy identifying number may be chosen at run-time. Made
      test_set_outermost_contour more general than test_outermost_contour
      was: longitude-latitude window and eddy identifying number may be
      chosen at run-time.
      
      For both test_max_speed_contour_ssh and test_set_outermost_contour,
      only the chosen longitude-latitude window is read from the NetCDF
      files. We have to call local_extrema because set_outermost_contour
      takes extr_map as an input argument (get_outermost_contour did not)
      and because longitude-latitude window and eddy identifying number may
      be chosen at run-time.
      6d746fb7
Loading