Use `uniform_lon_lat` from modules `input_ssh_m` or `read_grid_m` to
compute actual argument of `shpc_create`.

Replace dummy argument `grid_lon_lat` of procedure `shpc_create` by
`with_proj`.

Specify whether to read shapefile `extr_proj` in procedure `shpc_open`
instead of just trying to read this shapefile. Use `uniform_lon_lat`
to decide whether to read the shapefile. As `shpc_open` is called in
both programs `inst_eddies` and `eddy_graph`, we cannot access
variable `uniform_lon_lat` of module `input_ssh_m`, which is not used
in program `eddy_graph`, nor variable `uniform_lon_lat` of module
`read_grid_m`, which is not used in program `inst_eddies`. So we add a
dummy argument `with_proj` to procedure `shpc_open`.

I did not like the difference of treatment between corner and step.

We are trying to simplify the logic in program `inst_eddies`. Also,
the program `inst_eddies` should not write `grid_nml.txt` to the top
level of the SHPC directory since several instances could run in
parallel for several slices. So we are leaving it as a task for a
script above `inst_eddies` to create `grid_nml.txt` at the top level
of the SHPC directory. In tests, we have to move `grid_nml.txt` to
SHPC because we use `SHPC/grid_nml.txt` in other tests.

We are trying to simplify the logic in program `inst_eddies`. Also,
the program `inst_eddies` should not write `used_config_nml.txt` to
the top level of the SHPC directory since several instances could run
in parallel for several slices. So we are leaving it as a task for a
script over `inst_eddies` to create `used_config_nml.txt` at the top
level of the SHPC directory.

We want to be able to run `inst_eddies` from a directory other than
the directory containing the SHPC to be appended to. Preparing to
write `grid_nml.txt` and `used_config_nml.txt` in the current
directory. To be able to do this in parallel for several slices, we
need to be running in different directories.

Makes more sense.

So the user can get the usage message more easily.

Instead of reading command line arguments in procedure `input_ssh`,
read them outside and pass file names to `input_ssh`. This allows
`input_ssh` to be called by programs with different number of command
line arguments, in different positions. Preparing to make the
specification of uv-file optional.

This was not useful since we do not need an array of snapshots in
`inst_eddies`. It is clearer without the integration in a snapshot
variable. The integration in a snapshot variable came from initial
commit, when there was only one program for detection of instantaneous
eddies and overlapping.

Replace argument `s` of `write_snapshot` by its component `list`.

Replace argument `s` of `set_all_extr` by its components. The idea is
to remove the structure `snapshot` from program `inst_edddies`.

`MAX_RADIUS_deg` is not general enough for a non longitude latitude
grid. The variable `max_radius` moves from module `input_ssh_m` to
module `config_m`. The variable `MAX_RADIUS_deg` disappears. The
constraint `2 * max_radius_deg(1) < 180` becomes `4 * max_radius(1) <
nlon` but is only applied to the periodic case because we do not have
the general equivalent of 180° in number of points.

Promote nlon and nlat to variables of module `input_ssh_m`, avoiding
their repeated computation.

In main program units `inst_eddies`, `examine_eddy` and
`test_get_1_outerm`, redefine `outside_points` as coordinates in
projection space, avoiding a round trip to longitude and latitude. In
`examine_eddy`, we therefore store `coord_proj` instead of coord.

From `nearby_extr`.

Instead of `outside_points`.

Avoiding conversion back and forth to real.

Instead of corner.

Lionel GUEZ authored 9 months ago and GUEZ Lionel committed 8 months ago

Promote corner from dummy argument of `input_ssh` to variable of
module `input_ssh_m`. The dummy argument corner of `set_all_extr` is
also removed, since `set_all_extr` now accesses corner from
`input_ssh_m`. Motivation: preparation to access the corner of NetCDF
files from `get_1_outerm`.

It is `min_area` that we need in the code, in `get_1_outerm`. Instead
of computing it in the main program and trickling it down to
`get_1_outerm`, define it in `config_m`.

Split dummy argument `e` of `set_contours` into relevant components.
Motivation: make appear clearly input and output.

Replace dummy arguments `s` and `i` of procedure `set_contours` by
dummy argument `e`.

Move the computation of the search window for the outermost contour
and `outside_points` from procedure `set_contours` to main program
unit. The motivation is to have a clearer interface of procedure
`set_contours`, without `s` and `i`.

Rename module `set_all_contours_m` to `set_contours_m` and procedure
`set_all_contours` `set_contours`.

Move the loop on eddies out of `set_all_contours`, up into the main
program unit. The motivation is to be able to easily study a
particular eddy, having access to `cont_list` and corresponding speed
values.

Demote dummy arguments nlon and nlat of `input_ssh` to local
variables. nlon and nlat are no longer used in main program unit
`inst_eddies` since commit 03033711.

Rename procedure `set_all_outerm` to `set_all_contours` and module
`set_all_outerm_m` to `set_all_contours_m`.