Transmit projection coordinates of contour to `mean_speed`.

Lionel GUEZ authored 9 months ago and GUEZ Lionel committed 8 months ago

Transmit `cont_list_proj` from `get_1_outerm` to `set_max_speed`.

Lionel GUEZ authored 9 months ago and GUEZ Lionel committed 8 months ago

This is equivalent for a return value of `good_contour`. It is a
little faster to test a logical value, maybe.

Lionel GUEZ authored 9 months ago and GUEZ Lionel committed 8 months ago

We do not need it. we can just have a local variable at initialization.

Lionel GUEZ authored 9 months ago and GUEZ Lionel committed 8 months ago

Do not orient nor compute the area of `cont_list(n_cont)`. When the
area is too small, then we have one more copy than before, of
`cont_list(n_cont)` to `out_cont`, but, on the other hand, we have one
less call to `ccw_orient` than before. So this change should not
impact performance. Note that the orientation and area of
`cont_list(n_cont)` were not used after `get_1_outerm`.

Preparing to keep `cont_list` in projection coordinates.

Lionel GUEZ authored 9 months ago and GUEZ Lionel committed 8 months ago

Procedure `good_contour` now takes input in projection coordinates and
returns a contour in projection coordinates. The dummy argument step
of `good_contour` is thus removed.

Lionel GUEZ authored 9 months ago and GUEZ Lionel committed 8 months ago

Promote corner from dummy argument of `input_ssh` to variable of
module `input_ssh_m`. The dummy argument corner of `set_all_extr` is
also removed, since `set_all_extr` now accesses corner from
`input_ssh_m`. Motivation: preparation to access the corner of NetCDF
files from `get_1_outerm`.

Lionel GUEZ authored 9 months ago and GUEZ Lionel committed 8 months ago

This is a waste of computing time but we need to do this because we
are going to remove corner from the dummy arguments of `set_all_extr`.

Lionel GUEZ authored 9 months ago and GUEZ Lionel committed 8 months ago

Do not re-define `coord_proj` if it was read from a shapefile.

We want to be able to re-compute the cost, starting from the output of
a previous run of `cost_function.py`, when we have discarded the input
file of the previous run.

Segments is no longer a test with only isolated segments since commit
e1c18ad8.

Add tests `Cost_function_avg_date`, `Greece_date` and
`Eurec4A_cost_date`.

Add option `--avg_fix` in tests to reproduce previous behaviour.

The old behaviour: averaging over a maximum number of instantaneous
eddies, becomes an option.

We do not use bisect because `max_delta` should be small, around 6,
and most often there should be only one time step between
instantaneous eddies, so the first guess at distance `max_delta`
should be close to the result. Moreover, we would need to define a
date function if we used bisect.

Preparing for generalization of these functions.

This does not change any result, it is just an equivalent
formulation. We are preparing for a generalization of the choice of
`ip_beg` and `ip_end`.