In program `examine_eddy`.

Replace dummy argument `grid_lon_lat` of procedure `shpc_create` by
`with_proj`.

Rename variable `corner` of module `input_ssh_m` to `corner_whole`.

I did not like the difference of treatment between corner and step.

We are trying to simplify the logic in program `inst_eddies`. Also,
the program `inst_eddies` should not write `grid_nml.txt` to the top
level of the SHPC directory since several instances could run in
parallel for several slices. So we are leaving it as a task for a
script above `inst_eddies` to create `grid_nml.txt` at the top level
of the SHPC directory. In tests, we have to move `grid_nml.txt` to
SHPC because we use `SHPC/grid_nml.txt` in other tests.

We are trying to simplify the logic in program `inst_eddies`. Also,
the program `inst_eddies` should not write `used_config_nml.txt` to
the top level of the SHPC directory since several instances could run
in parallel for several slices. So we are leaving it as a task for a
script over `inst_eddies` to create `used_config_nml.txt` at the top
level of the SHPC directory.

We want to be able to run `inst_eddies` from a directory other than
the directory containing the SHPC to be appended to. Preparing to
write `grid_nml.txt` and `used_config_nml.txt` in the current
directory. To be able to do this in parallel for several slices, we
need to be running in different directories.

In program `examine_eddy`.

Change order of command line arguments of program
`examine_eddy`. Preparing to allow a variable number of NetCDF file
arguments.

Instead of reading command line arguments in procedure `input_ssh`,
read them outside and pass file names to `input_ssh`. This allows
`input_ssh` to be called by programs with different number of command
line arguments, in different positions. Preparing to make the
specification of uv-file optional.

Replace argument `s` of `set_all_extr` by its components. The idea is
to remove the structure `snapshot` from program `inst_edddies`.

`MAX_RADIUS_deg` is not general enough for a non longitude latitude
grid. The variable `max_radius` moves from module `input_ssh_m` to
module `config_m`. The variable `MAX_RADIUS_deg` disappears. The
constraint `2 * max_radius_deg(1) < 180` becomes `4 * max_radius(1) <
nlon` but is only applied to the periodic case because we do not have
the general equivalent of 180° in number of points.

Promote nlon and nlat to variables of module `input_ssh_m`, avoiding
their repeated computation.

In main program units `inst_eddies`, `examine_eddy` and
`test_get_1_outerm`, redefine `outside_points` as coordinates in
projection space, avoiding a round trip to longitude and latitude. In
`examine_eddy`, we therefore store `coord_proj` instead of coord.

Instead of `outside_points`.

Avoiding conversion back and forth to real.

Instead of corner.

Lionel GUEZ authored 9 months ago and GUEZ Lionel committed 8 months ago

Promote corner from dummy argument of `input_ssh` to variable of
module `input_ssh_m`. The dummy argument corner of `set_all_extr` is
also removed, since `set_all_extr` now accesses corner from
`input_ssh_m`. Motivation: preparation to access the corner of NetCDF
files from `get_1_outerm`.

Lionel GUEZ authored 9 months ago and GUEZ Lionel committed 8 months ago

This is a waste of computing time but we need to do this because we
are going to remove corner from the dummy arguments of `set_all_extr`.

It is `min_area` that we need in the code, in `get_1_outerm`. Instead
of computing it in the main program and trickling it down to
`get_1_outerm`, define it in `config_m`.

We need ssh of extremum in `set_contours`, to compute `innermost_level_2`.

Because we are going to use it for another field.

Instead of standard output.

Since it is not in the shapefiles.