Invert order of dummy arguments of procedure `read_grid`.

Use `uniform_lon_lat` from modules `input_ssh_m` or `read_grid_m` to
compute actual argument of `shpc_create`.

In program `test_read_eddy`.

Replace dummy argument `grid_lon_lat` of procedure `shpc_create` by
`with_proj`.

Specify whether to read shapefile `extr_proj` in procedure `shpc_open`
instead of just trying to read this shapefile. Use `uniform_lon_lat`
to decide whether to read the shapefile. As `shpc_open` is called in
both programs `inst_eddies` and `eddy_graph`, we cannot access
variable `uniform_lon_lat` of module `input_ssh_m`, which is not used
in program `eddy_graph`, nor variable `uniform_lon_lat` of module
`read_grid_m`, which is not used in program `inst_eddies`. So we add a
dummy argument `with_proj` to procedure `shpc_open`.

So that the program `eddy_graph` can read it, instead of deducing it
from the longitude coordinate.

The inpuy file has been re-created after commit 62ac3c9b.

Instead of storing it in the repository.

Replace argument `s` of `write_snapshot` by its component `list`.

Not worth it for a single point.

Lionel GUEZ authored 9 months ago and GUEZ Lionel committed 8 months ago

Do not re-define `coord_proj` if it was read from a shapefile.

`comp_ishape` can now compute `i_slice`.

Compute `i_slice` in `comp_ishape` if `i_slice` is None. Add default
value of None for dummy argument `i_slice`.

Move dummy argument `i_slice` of function `comp_ishape` to last
position. Because we are going to add a default value.

For `Test_compare` version > 0.4.

The algorithm of `eddy_graph` assumes that the set of dates it
processes is evenly spaced.

Because we are also going to use it to check continuity of dates
across slices.

We do not want a symbolic link `$tests_old_dir/Extract_component_nx_2`
to be created if directory `$tests_old_dir/Extract_component_nx_2`
does not exist.

For clarity. Possible since commit 7d6308f6.

There is a check on `min_inters` inside `inters_lines` but adding
these two tests in overlap can spare calls to `copy_shift`. Note that
we do not need to add such tests in the three other cases of nullity
of speed contours because, in these three other cases, if at least one
of `min_inters_speed` or `min_inters_out` is <= 1 then `p_shifted` is
used.

Optimize: shift `e1%out_cont%polyline` instead of shifting
`e2%speed_cont%polyline` and `e2%out%polyline`. This can save one call
to `copy_shift`.

If there are two speed-contours and they do not intersect, check
whether outermost contours intersect. The intersection threshold for
outermost contour is defined by new variable `min_inters_out`. Note
that the default value is such that results are not changed by this
commit if `min_inters_out` is left to its default value.

Distinguish the 4 cases with or without speed-contours. Preparing for
the new structure. We still have not changed any result.

Preparing for the new structure. Note that the code is
degraded (temporarily) because the definition of `polyline_1` is
repeated uselessly inside the loop on `l`.