Tilt-to-length does not cancel in locking beatnotes
Locking equations should be such that noises cancel in locking beatnotes.
However, it seems that tilt-to-length (TTL) noises do not cancel correctly in locking beatnotes, as seen below (N1-12 locking).
After careful inspection, it seems that the bug was introduced by !70 (merged), where all the signs were not correctly swapped. In conclusions, signs are wrong (should be switched to a "minus" sign) here:
- https://gitlab.in2p3.fr/lisa-simulation/instrument/-/blob/master/lisainstrument/instrument.py#L672
- https://gitlab.in2p3.fr/lisa-simulation/instrument/-/blob/master/lisainstrument/instrument.py#L690
- https://gitlab.in2p3.fr/lisa-simulation/instrument/-/blob/master/lisainstrument/instrument.py#L665
- https://gitlab.in2p3.fr/lisa-simulation/instrument/-/blob/master/lisainstrument/instrument.py#L683
These should be fixed and TTL cancelling in locking beatnotes tested again.
Edited by Jean-Baptiste Bayle