Resolve "Implement basic structure for the hexagon experiment"
All threads resolved!
Closes #94 (closed)
- New
Hexagon
class for hexagon simulations - A few associated unit tests
Edited by Jean-Baptiste Bayle
Merge request reports
Activity
added hexagon label
added 13 commits
-
3761b4d5...0d4aec35 - 11 commits from branch
master
- a9cbc8c2 - First attempt to simulate hexagon
- 51d19318 - 1st version of hexagon
-
3761b4d5...0d4aec35 - 11 commits from branch
requested review from @j2b.bayle
- Resolved by Jean-Baptiste Bayle
That looks really good. Can you just add your name and email at the top of the file, in the author list?
added 9 commits
- 519024fe - First attempt to simulate hexagon
- ce8bbac5 - write() and _write_attr()
- 197602a8 - Fix Pylint warnings
- c35263b4 - Add Kohei as author
- 6f5758b4 - Fix missing documentation
- 79962513 - Minor changes
- 017c4839 - Add logging to simulation
- 60552a43 - Refactor writing functions
- b018c59d - Fix unit tests
Toggle commit list- Resolved by Jean-Baptiste Bayle
I've added a couple of fixes and changes (mostly cosmetic, and tests).
I've changed the write function so that it's closer to what we have in
Instrument
(or what it soon will be). Can you check that it's okay with you?Edited by Jean-Baptiste Bayle
mentioned in commit ed968c75
Please register or sign in to reply