Resolve "Dependency pyplnoise is no longer available"

Closes #99 (closed)

• Remove pyplnoise as a dependecy
• Add pyplnoise as a submodule

changed milestone to %v1.1

added bug urgent labels

added 1 commit

• dc5f7e2e - Remove pyplnoise dependency and add package

Compare with previous version

requested review from @j2b.bayle

added 1 commit

• 5c11649c - Fix import order

Compare with previous version

Hi @j2b.bayle,

this seems to work in a venv on my machine.. can you check if I missed something? First time I'm messing with the python packaging.

I added a subpackage for dependencies, where I copied both the .py and the license file. I wasn't sure if I should add those also to lisainstrument.egg-info/SOURCES.txt, for now I did not. I also didn't copy any of the other metadata of the package, like the readme file, which contains some examples.

added 2 commits

• a79b490b - Rename pyplnoise submodule
• 1b4be1c6 - Fix Pylint tests

Compare with previous version

marked this merge request as ready

Hi @olaf, thanks for looking into this.

I've just renamed the submodule "pyplnoise" to retain the original name, and therefore just used the original module structure, with the licence file as usual. To be faire, we probably miss quite a few things, like unit tests for this module, readme's and other accompanying documents -- but that's probably okay.

I've tested it on a venv as well, and it seems to work!

Let's wait for Jan's reply before merging this.

approved this merge request

changed the description

added 1 commit

• c921d225 - Add acknowledgement for pyplnoise in README

Compare with previous version

Jan Waldmann replied very kindly,

Dear Jean-Baptiste,

Apologies for the inconsiderate deletion of pyplnoise from PyPI! I hope it did not cause you too much trouble. During a recent cleanup I deleted the project under the assumption that nobody was using it and knowing that I’m not up to date on recent developments in Python/NumPy/SciPy.

The mistake has been corrected - a version 1.4 has been pushed to PyPI and the repository has been made visible again. It is the same code as before but with a warning about the lack of maintenance (the version increment was mandated by PyPI). The BSD license allows you to fork it, copy and modify it as you wish!

So I suggest that we still merge this MR to prevent any future issues, but keep a reference to the original project on Github. To this end, I've added a "Special Acknowledgment" section on the README, thanking the author, citing the original paper, and with a link to the pyplnoise project on Github.

@ohartwig, what do you think?

mentioned in merge request !122 (merged)

@mastaa could you take a look as well, and check that you can install and run everything on your machine?

It runs on my machine without a problem!

approved this merge request

merged

mentioned in commit e3158f0c