Rather than calling dbffileisnull or shpfileisnull. This should be
faster and more robust.

Of derived type `shpc_slice_handler`.

Specify whether to read shapefile `extr_proj` in procedure `shpc_open`
instead of just trying to read this shapefile. Use `uniform_lon_lat`
to decide whether to read the shapefile. As `shpc_open` is called in
both programs `inst_eddies` and `eddy_graph`, we cannot access
variable `uniform_lon_lat` of module `input_ssh_m`, which is not used
in program `eddy_graph`, nor variable `uniform_lon_lat` of module
`read_grid_m`, which is not used in program `inst_eddies`. So we add a
dummy argument `with_proj` to procedure `shpc_open`.

Lionel GUEZ authored 8 months ago and GUEZ Lionel committed 8 months ago

We do not need it. we can just have a local variable at initialization.

Since getting `i_slice` is now cheaper.

Return `i_slice` instead. Since getting `i_slice` is now cheaper.

Instead of defining `self._n_dates` with zeroes. So we do not need the
function `get_n_dates` any longer.

Do not define `self._ishape_last[i_slice][orientation]` in
`_create_ishape_last`. Return a numpy array instead. Clearer.

Compute `i_slice` in `comp_ishape` if `i_slice` is None. Add default
value of None for dummy argument `i_slice`.

Move dummy argument `i_slice` of function `comp_ishape` to last
position. Because we are going to add a default value.

For `Test_compare` version > 0.4.

Move functions `node_to_date_eddy` and `date_eddy_to_node` from script
`report_graph.py` to script `util_eddies.py`. `util_eddies.py`
contains more basic functions, it only imports
shapefile. `report_graph.py` imports networkx. It was not convenient
nor meaningful to require networkx for scripts that use
`node_to_date_eddy` or `date_eddy_to_node`.

This was polluting standard output. So we have to add the shapefile
path when it is not found.

OSError is more specific than SystemExit. It is better to have a more
specific exception when we want to catch it.

Invert order of dummy arguments orientation and layer of method
`get_reader`. Take the same order than in the path. `orientation` was at
the end because, at first, in commit d858fb72, it was an optional
argument.

Check that `SHPC_dir` exists at initialization of instance of class
SHPC. Before this commit, if `SHPC_dir` did not exist, there was an
error trying to create `n_slices.txt`, which was less clear.

Remove unused procedures and programs `inside_4`,
`max_speed_contour_ssh`, `test_inside_4`,
`test_max_speed_contour_ssh`. Unused since commit 99e2e1b1.