Skip to content
Snippets Groups Projects
PIGOU Maxime's avatar
commented on issue #46 "Deploy lisaconstants on conda-forge?" at LISA Simulation / LISA Constants

(this can take a few weeks)...

PIGOU Maxime's avatar
commented on issue #46 "Deploy lisaconstants on conda-forge?" at LISA Simulation / LISA Constants

@j2b.bayle could you please add a comment on https://github.com/conda-forge/staged-recipes/pull/29544 stating that you accept being a maintainer? T...

PIGOU Maxime's avatar
commented on issue #46 "Deploy lisaconstants on conda-forge?" at LISA Simulation / LISA Constants

Great I'll do that then!...

Jean-Baptiste Bayle's avatar
commented on issue #46 "Deploy lisaconstants on conda-forge?" at LISA Simulation / LISA Constants

I see; thanks for taking the time to include the authors of the package in the loop....

PIGOU Maxime's avatar
commented on issue #46 "Deploy lisaconstants on conda-forge?" at LISA Simulation / LISA Constants

Exactly, for you it's entirely transparent! You don't need to change a thing here on the base project....

Jean-Baptiste Bayle's avatar
commented on issue #46 "Deploy lisaconstants on conda-forge?" at LISA Simulation / LISA Constants

Thanks again for the explanation!...

PIGOU Maxime's avatar
commented on issue #46 "Deploy lisaconstants on conda-forge?" at LISA Simulation / LISA Constants

conda-forge does not work in the same way as PyPI in the sense that you cannot build yourself the conda package then push it to a repository in the...

Jean-Baptiste Bayle's avatar
commented on issue #46 "Deploy lisaconstants on conda-forge?" at LISA Simulation / LISA Constants

I see, thank you for your explanation....

PIGOU Maxime's avatar
commented on issue #46 "Deploy lisaconstants on conda-forge?" at LISA Simulation / LISA Constants

Thanks for your answer @j2b.bayle ,...

Jean-Baptiste Bayle's avatar
commented on issue #46 "Deploy lisaconstants on conda-forge?" at LISA Simulation / LISA Constants

Hi @maxime.pigou,...

PIGOU Maxime's avatar
opened issue #46 "Deploy lisaconstants on conda-forge?" at LISA Simulation / LISA Constants
Jean-Baptiste Bayle's avatar
deleted branch 41-change-header-generation-method at LISA Simulation / LISA Constants
Jean-Baptiste Bayle's avatar
closed issue #41 "Change header generation method" at LISA Simulation / LISA Constants
Jean-Baptiste Bayle's avatar
Jean-Baptiste Bayle's avatar
accepted merge request !65 "Resolve "Change header generation method"" at LISA Simulation / LISA Constants
Jean-Baptiste Bayle's avatar
commented on merge request !65 "Resolve "Change header generation method"" at LISA Simulation / LISA Constants

Created an issue in #45....

Jean-Baptiste Bayle's avatar
opened issue #45 "Add unit tests to check that the C/C++ generated header files compile" at LISA Simulation / LISA Constants
Wolfgang Kastaun's avatar
commented on merge request !65 "Resolve "Change header generation method"" at LISA Simulation / LISA Constants

Looks fine. I was thinking that a unit test if the generated headers compile would be good, but that sounds like another MR.

Wolfgang Kastaun's avatar
approved merge request !65 "Resolve "Change header generation method"" at LISA Simulation / LISA Constants
Jean-Baptiste Bayle's avatar
commented on merge request !65 "Resolve "Change header generation method"" at LISA Simulation / LISA Constants

That should be good now 😊.