Resolve "Completely unrealistic beatnote frequencies for 'six' laser locking configuration"

Closes #86 (closed)

• Add a parameter offset_freqs with default set of values
• Set laser frequency offset to relevant value in offset_freqs if laser is locked on cavity
• Add unit tests to check that offset_freqs is correctly used

added bug label

changed milestone to %v1.1

marked this merge request as ready

changed the description

requested review from @ohartwig

@ohartwig that should be it!

added 4 commits

• 2ff76482...55949e61 - 3 commits from branch master
• 2310257d - Use offset frequencies for unlocked lasers

Compare with previous version

And here's the rebase!

requested review from @mastaa and removed review request for @ohartwig

Hi @j2b.bayle!

Code looks good. I also ran two short test cases:

1. without passing the orbits parameter (basically your unit test).
2. with esa orbits. Here I get 26MHz for one of the ISI beatnotes which is not too far off.

Works great and I guess if people want to use orbits different to the default PPRs they might want to tweak the offsets if the 5<f<25MHz condition is relevant.

I think this is good to go! :)

approved this merge request

Awesome, thanks @mastaa!

merged

mentioned in commit 8fc575a2