Resolve "Do not accept fplan files for simulations without an orbit files"
Merged
requested to merge 138-do-not-accept-fplan-files-for-simulations-without-an-orbit-files into master
Closes #138 (closed)
- Raise an error when the path to a frequency-plan file is given with custom PPRs (ie., when no orbit files are given)
Merge request reports
Activity
changed milestone to %v1.6
added feature label
requested review from @ohartwig
assigned to @j2b.bayle
These few changes ought to do it @ohartwig!
added 11 commits
-
3dec1759...03831647 - 7 commits from branch
master
- df3db04a - Refuse to use fplan file if no orbit files used
- 0781a957 - Warn when using static locking beatnote freqs
- 6926b46f - Fix the fplan unit tests
- a6bbcd0a - Disable pylint warning
Toggle commit list-
3dec1759...03831647 - 7 commits from branch
@ohartwig do you think you'll have a bit of time to look at this before the end of the week?
If not, I'll go ahead and merge it immediately to release the long-awaited v1.6. We need to move forward to work on the optimization.
removed review request for @ohartwig
@ohartwig since you don’t have much time, I’ll go ahead and merge this. If there’s any bug introduced by these changes we’ll fix them in a future MR.
mentioned in commit ba47822d
Please register or sign in to reply