Resolve "Check coupling of GWs"

Closes #18 (closed)

• Change GW coupling factors from self.central_freq to -(self.central_freq + self.local_carrier_offsets) (and equivalent for sidebands)

lisainstrument/instrument.py

@@ -668,7 +668,7 @@ class Instrument:
             .transformed(lambda mosa, x: self.interpolate(x, -self.pprs[mosa]))
         self.distant_carrier_fluctuations = \
             propagated_carrier_fluctuations \
-            + (self.central_freq + self.local_carrier_offsets) * self.gws \
+            - (self.central_freq + self.local_carrier_offsets) * self.gws \
             + (self.central_freq + self.local_carrier_offsets) * self.local_ttls / c
 
         logger.debug("Propagating upper sideband offsets to distant MOSAs")
@@ -686,7 +686,7 @@ class Instrument:
             .transformed(lambda mosa, x: self.interpolate(x, -self.pprs[mosa]))
         self.distant_usb_fluctuations = \
             propagated_usb_fluctuations \
-            + (self.central_freq + self.local_usb_offsets) * self.gws \
+            - (self.central_freq + self.local_usb_offsets) * self.gws \
             + (self.central_freq + self.local_usb_offsets) * self.local_ttls / c
 
         logger.debug("Propagating timer deviations to distant MOSAs")
@@ -1336,7 +1336,7 @@ class Instrument:
                 * self.distant_ttls[distant(mosa)] / c
         distant_carrier_fluctuations = \
             (1 - self.d_pprs[mosa]) * self.interpolate(carrier_fluctuations, -self.pprs[mosa]) \
-            + (self.central_freq + self.local_carrier_offsets[mosa]) * self.gws[mosa] \
+            - (self.central_freq + self.local_carrier_offsets[mosa]) * self.gws[mosa] \
             - (self.central_freq + self.local_carrier_offsets[mosa]) * self.local_ttls[mosa] / c
         self.local_carrier_fluctuations[mosa] = distant_carrier_fluctuations \
             + self.offsets_freqs[mosa] * self.clock_noise_fluctuations[sc(mosa)] \
@@ -1360,7 +1360,7 @@ class Instrument:
                 * self.distant_ttls[distant(mosa)] / c
         distant_usb_fluctuations = \
             + (1 - self.d_pprs[mosa]) * self.interpolate(usb_fluctuations, -self.pprs[mosa]) \
-            + (self.central_freq + self.local_usb_offsets[mosa]) * self.gws[mosa] \
+            - (self.central_freq + self.local_usb_offsets[mosa]) * self.gws[mosa] \
             - (self.central_freq + self.local_usb_offsets[mosa]) * self.local_ttls[mosa] / c
         self.local_usb_fluctuations[mosa] = distant_usb_fluctuations \
             + self.offsets_freqs[mosa] * self.clock_noise_fluctuations[sc(mosa)] \