Run the jslint checker.

static/plugin_dbui/src/grid/property/Preferences.js

@@ -11,7 +11,7 @@ Ext.define('App.grid.property.Preferences', {
     alias: 'widget.xpreferences',
 
     /**
-     * @cfg {String} dbtable
+     * @cfg {String} dbtable (required)
      * The database table containing the property and their values
      */
     dbtable: "preferences",
@@ -55,7 +55,7 @@ Ext.define('App.grid.property.Preferences', {
                 minWidth: 80,
                 text: me.textUpdate,
                 scope: me
-            },{
+            }, {
                 handler: me.onButtonReset,
                 minWidth: 80,
                 text: me.textReset,
@@ -76,8 +76,6 @@ Ext.define('App.grid.property.Preferences', {
         // initialise the base class
         me.callParent(arguments);
 
-        // link the buttons
-
         // load the store and fill the grid property
         me.refStore.load({
             callback: me.onRefStoreLoad,
@@ -89,19 +87,19 @@ Ext.define('App.grid.property.Preferences', {
      * load the store and fill the grid property
      *
      */
-    onRefStoreLoad: function(records, operation, success) {
+    onRefStoreLoad: function (records, operation, success) {
 
         "use strict";
 
         var me = this,
-            data = {},
-            i, property, value;
+            data = {};
 
-        for (i = 0; i < records.length; i += 1) {
-            property = records[i].get(me.fieldProperty);
-            value = records[i].get(me.fieldValue);
+        records.forEach(function (record) {
+            var property, value;
+            property = record.get(me.fieldProperty);
+            value = record.get(me.fieldValue);
             data[property] = value;
-        }
+        });
 
         me.setSource(data, me.sourceConfig);
     },
@@ -125,17 +123,15 @@ Ext.define('App.grid.property.Preferences', {
         "use strict";
         var me = this,
             data = me.getSource(),
-            i, newValue, oldValue, properties, record;
-
-        // the list of property
-        properties = Object.keys(data);
+            properties = Object.keys(data);
 
         // find the record associate to each property
         // update it if necessarily
-        for (i = 0; i < properties.length; i += 1) {
-            record = me.refStore.findRecord(me.fieldProperty, properties[i]);
+        properties.forEach(function (property) {
+            var newValue, oldValue, record;
+            record = me.refStore.findRecord(me.fieldProperty, property);
 
-            newValue = data[properties[i]];
+            newValue = data[property];
             oldValue = record.get(me.fieldValue);
 
             if (newValue !== oldValue) {
@@ -143,7 +139,7 @@ Ext.define('App.grid.property.Preferences', {
                 record.set(me.fieldValue, newValue);
                 record.endEdit();
             }
-        }
+        });
 
         // close the window housing the preferences widget
         // simple logic based on the owner container