Better Coding for grid.mixin.ExportLatex.

static/plugin_dbui/src/grid/mixin/ExportLatex.js

@@ -56,20 +56,10 @@ Ext.define('App.grid.mixin.ExportLatex', {
         "use strict";
 
         var me = this,
-            cells,
-            cmd,
             columnsAlignment = '',
             columnHeader,
-            div,
-            i,
-            j,
             latex = [],
-            nColumns,
-            tdEl,
-            tdEls,
-            trEl,
             trEls,
-            row,
             total;
 
         // build the column alignment, e.g. llrrc
@@ -78,9 +68,6 @@ Ext.define('App.grid.mixin.ExportLatex', {
             columnsAlignment += value[0];
         });
 
-        // alias
-        nColumns = columnHeader.alignments.length;
-
         // begin table
         latex.push('\\begin{longtable}{' + columnsAlignment + '}');
 
@@ -99,15 +86,16 @@ Ext.define('App.grid.mixin.ExportLatex', {
         trEls = me.getView().getEl().select("table tr");
 
         // process the trEls Ext.dom.CompositeElement
-        for (i = 0; i < trEls.getCount(); i += 1) {
+        trEls.each(function (trEl, compositeElement, index) {
 
-            trEl = trEls.item(i);
+            var cells, cmd, div, nColumns, tdEls, row;
 
             // grouping row. It is represent as a latex multicolumn
             if (trEl.hasCls("x-grid-wrap-row")) {
 
                 div = trEl.down(".x-grid-group-title");
                 if (div) {
+                    nColumns = columnHeader.alignments.length;
                     cmd = '\\multicolumn{' + nColumns + '}{l}{' + me.domToLaTeX(div) + '} \\\\';
                     latex.push(cmd);
                     latex.push('\\hline');
@@ -120,20 +108,20 @@ Ext.define('App.grid.mixin.ExportLatex', {
                 tdEls = trEl.select("td");
 
                 // process the tdEls Ext.dom.CompositeElement
-                for (j = 0; j < tdEls.getCount(); j += 1) {
-                    cells.push(me.domToLaTeX(tdEls.item(j)));
-                }
+                tdEls.each(function (tdEl) {
+                    cells.push(me.domToLaTeX(tdEl));
+                }, me);
 
                 row = cells.join(' & ') + ' \\\\';
 
-                // unfortunately the grand total appear as the first row (Ext JS 4.2)
-                if (i === 0 && trEl.hasCls("x-grid-row-summary")) {
+                // unfortunately the grand total is the first row (Ext JS 4.2)
+                if (index === 0 && trEl.hasCls("x-grid-row-summary")) {
                     total = row;
                 } else {
                     latex.push(row);
                 }
             }
-        }
+        }, me);
 
         // push the grand total at the end
         if (total) {