* fixing seg fault with analysis of analysis FDC

NPLib/TrackReconstruction/NPDCReconstructionMT.cxx

@@ -18,7 +18,11 @@
  *****************************************************************************/
 
 #include"NPDCReconstructionMT.h"
+
+// ROOT
 #include "Math/Factory.h"
+#include "Math/Minimizer.h"
+#include "Math/Functor.h"
 #include "TError.h"
 #include "TGraph.h"
 #include "TVector3.h"
@@ -29,6 +33,9 @@ using namespace NPL;
 ////////////////////////////////////////////////////////////////////////////////
 DCReconstructionMT::DCReconstructionMT(unsigned int number_thread){
   m_nbr_thread= number_thread;
+  // force loading of the minimizer plugin ahead
+  ROOT::Math::Minimizer* mini=ROOT::Math::Factory::CreateMinimizer("Minuit2", "Migrad"); 
+  delete mini;
 }
 ////////////////////////////////////////////////////////////////////////////////
 DCReconstructionMT::~DCReconstructionMT(){
@@ -190,10 +197,8 @@ void NPL::DCReconstructionMT::InitThreadPool(){
   m_Ready.clear();
   m_Ready.resize(m_nbr_thread,false);
   for (unsigned int i=0; i < m_nbr_thread; i++) { 
-    //Create the minimiser (deleted by the thread)
-    ROOT::Math::Minimizer* mini=ROOT::Math::Factory::CreateMinimizer("Minuit2", "Migrad"); 
     // Register minimiser for futur deletion
-    m_ThreadPool.push_back( std::thread(&NPL::DCReconstructionMT::StartThread,this,mini,i) );
+    m_ThreadPool.push_back( std::thread(&NPL::DCReconstructionMT::StartThread,this,i) );
   }
   m_stop = false;
   for(auto& th: m_ThreadPool){
@@ -201,17 +206,21 @@ void NPL::DCReconstructionMT::InitThreadPool(){
   }
 }
 ////////////////////////////////////////////////////////////////////////////////
-void DCReconstructionMT::StartThread(ROOT::Math::Minimizer* mini,unsigned int id){
-  // Let the main thread start 
-  std::this_thread::sleep_for(std::chrono::milliseconds(100));
+void DCReconstructionMT::StartThread(unsigned int id){
+  // usefull variable
+  double ai,bi;
+  unsigned int uid;
+  const double* xs;
   // create the functor 
   // each threads needs its own or the minisation is not thread safe 
   ROOT::Math::Functor* func= new ROOT::Math::Functor(this,&NPL::DCReconstructionMT::SumD,3); 
+  //Create the minimiser (deleted by the thread)
+  ROOT::Math::Minimizer* mini=ROOT::Math::Factory::CreateMinimizer("Minuit2", "Migrad"); 
   mini->SetFunction(*func);
   mini->SetPrintLevel(0);
-  double ai,bi;
-  unsigned int uid;
-  const double* xs;
+
+  // Let the main thread start
+  std::this_thread::sleep_for(std::chrono::milliseconds(100));
   while(true){
     // Do the job if possible
     if(m_Ready[id]){

NPLib/TrackReconstruction/NPDCReconstructionMT.h

@@ -40,10 +40,6 @@
 #include <map>
 #include <vector>
 #include <thread>
-// ROOT
-#include "Math/Minimizer.h"
-#include "Math/Functor.h"
-
 class TVector3;
 class TGraph;
 namespace NPL{
@@ -97,7 +93,6 @@ namespace NPL{
       long double av,bv,au,bu;
       double xM,yM;
 
-
     private: // Thread Pool defined if C++11 is available
       unsigned int m_nbr_thread;
       std::vector<std::thread> m_ThreadPool;
@@ -107,7 +102,7 @@ namespace NPL{
     public: // Init the Thread Pool
 
       void InitThreadPool(); 
-      void StartThread(ROOT::Math::Minimizer*,unsigned int);
+      void StartThread(unsigned int);
       void StopThread();
       bool IsDone();